Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10545: fix Option to disable identify popup in case of no results #10619

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

mahmoudadel54
Copy link
Contributor

Description

In this PR, I have fixed the issue mentioned in this comment: #10557 (comment) by removing the marker in case no identify result + hover identify mode active and identify cfg hideEmptyPopupOption with true

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: enhancement

Issue

#10545

What is the current behavior?
#10557 (comment)
What is the new behavior?
If user activates hover identify mode and there is identify cfg hideEmptyPopupOption = true in localConfig then user clicks on a place with no identify results ---> the blue marker will be removed automatically from map.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

…ify mode active and hideEmptyPopupOption with true
@mahmoudadel54 mahmoudadel54 added enhancement BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C044-VLAANDEREN-2024-SUPPORT labels Oct 17, 2024
@mahmoudadel54 mahmoudadel54 added this to the 2024.02.01 milestone Oct 17, 2024
@mahmoudadel54 mahmoudadel54 requested a review from MV88 October 17, 2024 12:12
@mahmoudadel54 mahmoudadel54 self-assigned this Oct 17, 2024
@mahmoudadel54 mahmoudadel54 linked an issue Oct 17, 2024 that may be closed by this pull request
6 tasks
@MV88 MV88 merged commit 0101c6b into geosolutions-it:master Oct 17, 2024
6 checks passed
@MV88
Copy link
Contributor

MV88 commented Oct 17, 2024

@ElenaGallo please test this in DEV

jnewmoyer pushed a commit to ngsllc/MapStore2 that referenced this pull request Oct 17, 2024
* Update Changelog for version 2024.02.00 (geosolutions-it#10602)

Co-authored-by: github-actions <github-actions@github.com>

* Bump commons-io:commons-io from 2.7 to 2.14.0 (geosolutions-it#10593)

* Removed react-confirm-button unused dependency (geosolutions-it#10495)

* Update release_steps.md (geosolutions-it#10568)

* Remove istambul loader (geosolutions-it#10491)

* Attempt to remove instambul loader

* removed also package dependency

* Apply suggestions from code review

clean

* Remove jsonpath (geosolutions-it#10494)

jsonpath is not needed. It is a dependency of geosolutions-it/patcher actually.
Having this dependency here is only confusing for dependency analyisis

* Fix geosolutions-it#10595 add missing 'FORMAT' parameter to WMTS GetFeatureInfo requests (geosolutions-it#10596)

* add missing 'FORMAT' parameter to WMTS GetFeatureInfo requests

this is required by the WMTS spec to be the same format as would
be used for a GetTile request, and this allows GFI requests to
succeed on https://data.geopf.fr/wmts.

* fix mapinfo wmts utils test

* Fix geosolutions-it#10505 Allow to specify use of proxy or cors at layer level (geosolutions-it#10526)

* fix: remove ui element for force proxy and Allow not secure layers

* fix: ajax logic changed, autoDetectCORS is set to true by default

* new central CORS util file created and used in ajax

* checking CORS before adding in common layer file

* null check on getProxyUrl

* updated individual layer considring to use proxy if needed

* avoid proxy cache to update if response is not okey

* enable user to add http url, show warning instead of error, warning text updated

* test cases updated

* fix: resolve conflicts with url check

* fixed the failed test

* review cesium layers

* include add method in model layer

* improve http check for openlayers wms layer

* fix tests

---------

Co-authored-by: allyoucanmap <stefano.bovio@geosolutionsgroup.com>

* Update openId.md (geosolutions-it#10610)

* Bump spring-security version to 5.7.12 (fixes geosolutions-it#10611) (geosolutions-it#10612)

somehow something in the build already drags this version, and we
end up with two conflicting versions of spring-security in the war
which results in at least failure to authenticate with basic auth.

* Visibility limits - The resolution option is not retained as Limits type geosolutions-it#10391 (geosolutions-it#10598)

* Add lib check release step (geosolutions-it#10614)

* geosolutions-it#4675 Remove unused code (geosolutions-it#10442)

* geosolutions-it#4675 Remove unused code

* remove additional code from review

* fix tests folder

* remove additional unused files

* geosolutions-it#10545: Option to disable identify popup in case of no results (geosolutions-it#10557)

* geosolutions-it#10545: Option to disable identify popup in case of no results
Description:
- handle adding an option called 'hidePopupIfNoResults' to hide the identify popup
- add unit tests
- add jsdoc

* geosolutions-it#10545: Option to disable identify popup in case of no results
Description:
- revert changes in popupSupport files for ol and leaflet + related tests files
- handle hide popup for map viewer with css for openlayers and leaflet approach
- add unit tests
- edit map-popup.less file to handle hide the popup

* geosolutions-it#10545: revert unnecessary changes

* Fix geosolutions-it#10615 removed eval from marker utils (geosolutions-it#10616)

* geosolutions-it#10545: remove marker in case no results + hover identify mode active and hideEmptyPopupOption with true (geosolutions-it#10619)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lorenzo Natali <lorenzo.natali@geosolutionsgroup.com>
Co-authored-by: Landry Breuil <landryb@users.noreply.github.com>
Co-authored-by: RowHeat <40065760+rowheat02@users.noreply.github.com>
Co-authored-by: allyoucanmap <stefano.bovio@geosolutionsgroup.com>
Co-authored-by: mahmoud adel <58145645+mahmoudadel54@users.noreply.github.com>
Co-authored-by: Matteo V. <matteo.velludini@geosolutionsgroup.com>
offtherailz pushed a commit that referenced this pull request Oct 18, 2024
@ElenaGallo
Copy link
Contributor

Test passed, @mahmoudadel54 please backport to 2024.02.xx. Thanks

mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this pull request Oct 23, 2024
@mahmoudadel54
Copy link
Contributor Author

Test passed, @mahmoudadel54 please backport to 2024.02.xx. Thanks

@ElenaGallo
backport is done ---> #10624

tdipisa pushed a commit that referenced this pull request Oct 24, 2024
…ase of no results (#10624)

* #10545: Option to disable identify popup in case of no results (#10557)

* #10545: Option to disable identify popup in case of no results
Description:
- handle adding an option called 'hidePopupIfNoResults' to hide the identify popup
- add unit tests
- add jsdoc

* #10545: Option to disable identify popup in case of no results
Description:
- revert changes in popupSupport files for ol and leaflet + related tests files
- handle hide popup for map viewer with css for openlayers and leaflet approach
- add unit tests
- edit map-popup.less file to handle hide the popup

* #10545: revert unnecessary changes

* #10545: remove marker in case no results + hover identify mode active and hideEmptyPopupOption with true (#10619)
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable identify popup in case of no results
4 participants