fix #1151 fixed some warnings #1226
Conversation
| @@ -90,7 +90,7 @@ var MapGrid = React.createClass({ | |||
| renderMetadataModal() { | |||
| if (this.props.metadataModal) { | |||
| let MetadataModal = this.props.metadataModal; | |||
| return (<MetadataModal ref="metadataModal" show={this.props.currentMap && this.props.currentMap.displayMetadataEdit} onHide={this.props.resetCurrentMap} | |||
| return (<MetadataModal key="metadataModal" show={this.props.currentMap && this.props.currentMap.displayMetadataEdit} onHide={this.props.resetCurrentMap} | |||
There was a problem hiding this comment.
You cannot remove the ref, it's used
There was a problem hiding this comment.
ok i will keep ref and add key
| @@ -17,15 +17,15 @@ const CreateNewMap = React.createClass({ | |||
| mapType: React.PropTypes.string, | |||
| onGoToMap: React.PropTypes.func, | |||
| colProps: React.PropTypes.object, | |||
| isLoggedIn: React.PropTypes.bool | |||
| isLoggedIn: React.PropTypes.object | |||
There was a problem hiding this comment.
bool is correct. You need to change the connect to set a bool value
| }, | ||
| contextTypes: { | ||
| router: React.PropTypes.object | ||
| }, | ||
| getDefaultProps() { | ||
| return { | ||
| mapType: "leaflet", | ||
| isLoggedIn: false, | ||
| isLoggedIn: "", |
There was a problem hiding this comment.
ok i will change this
|
yes as far i have seen there are other two warnings
|
|
Ok, then fix also the two remaining warnings |
|
Is the "when we will click on settings icon in layer properties" still there? |
| @@ -51,6 +51,6 @@ const CreateNewMap = React.createClass({ | |||
| module.exports = { | |||
| CreateNewMapPlugin: connect((state) => ({ | |||
| mapType: (state.maps && state.maps.mapType) || (state.home && state.home.mapType), | |||
| isLoggedIn: state && state.security && state.security.user | |||
| isLoggedIn: state && state.security && state.security.user && state.security.user.enabled | |||
There was a problem hiding this comment.
isLoggedIn: state && state.security && state.security.user && true || false
There was a problem hiding this comment.
ok i will change
| @@ -385,7 +385,7 @@ | |||
| "closeGlyph": "1-close", | |||
| "submitConfig": { | |||
| "buttonConfig": { | |||
| "bsSize": "medium", | |||
| "bsSize": "small", | |||
There was a problem hiding this comment.
Have you checked that the button doesn't change?
There was a problem hiding this comment.
yes i checked its changed
No description provided.