Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional custom zoomToFeature action #1234

Merged
merged 2 commits into from
Nov 2, 2016
Merged

Added optional custom zoomToFeature action #1234

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92b2984
Added optional custom zoomToFeature action
Nov 2, 2016
5400e8a
Added test and fix on Mauro's review
Nov 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions web/client/components/data/featuregrid/FeatureGrid.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ const FeatureGrid = React.createClass({
toolbar: React.PropTypes.object,
dataSource: React.PropTypes.object,
selectAll: React.PropTypes.func,
selectAllActive: React.PropTypes.bool
selectAllActive: React.PropTypes.bool,
zoomToFeatureAction: React.PropTypes.func
},
contextTypes: {
messages: React.PropTypes.object
Expand Down Expand Up @@ -245,7 +246,11 @@ const FeatureGrid = React.createClass({
zoomToFeature(params) {
let geometry = params.data.geometry;
if (geometry.coordinates) {
this.changeMapView([geometry], this.props.zoom);
if (this.props.zoomToFeatureAction) {
this.props.zoomToFeatureAction(params.data, params.data.geometry);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you pass params.data, you don't need the 2nd argument

} else {
this.changeMapView([geometry], this.props.zoom);
}
}
},
zoomToFeatures() {
Expand Down