Add point measurement support #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarto
suggested changes
Dec 13, 2016
| @@ -105,6 +114,7 @@ const MeasurementSupport = React.createClass({ | |||
| areaMeasureEnabled: this.props.measurement.areaMeasureEnabled, | |||
| bearingMeasureEnabled: this.props.measurement.bearingMeasureEnabled, | |||
| geomType: this.props.measurement.geomType, | |||
| point: null, // handled in onDraw.created | |||
There was a problem hiding this comment.
Probably we also need a pointMeasureEnabled: ... here?
There was a problem hiding this comment.
Indeed, commit amended. BTW I'll have a followup PR which will clean up the code a bit.
manisandro
force-pushed
the
pointmeasure
branch
from
c3d4101 to
57cbf15
Compare
mbarto
approved these changes
Dec 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a measurement mode for measuring point coordinates.