Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also update measurements on mouse move #1350

Merged
merged 2 commits into from
Dec 13, 2016

Conversation

manisandro
Copy link
Contributor

Also update the measurement values while moving the mouse. Includes some code cleanups along the way.

@simboss simboss added the ready label Dec 13, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 80.194% when pulling 520e815 on sourcepole:measure_on_mouse_move into a02f82f on geosolutions-it:master.

Copy link
Contributor

@mbarto mbarto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the update on mouse move optional and disabled by default?

@manisandro
Copy link
Contributor Author

manisandro commented Dec 13, 2016

Uhm, it's a bit hard to inject properties into the MeasurementSupport components from the global config. Or shall I abuse state.measurement for this (i.e. state.measurement.updateOnMousemove)?

@mbarto
Copy link
Contributor

mbarto commented Dec 13, 2016

You should be able to use the Map plugin toolsOptions property to pass down properties to the tool

@manisandro
Copy link
Contributor Author

Ah missed that one, I'll have a look, thanks.

@manisandro manisandro force-pushed the measure_on_mouse_move branch from dd3e1ba to a3a2f5c Compare December 13, 2016 16:27
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 80.072% when pulling a3a2f5c on sourcepole:measure_on_mouse_move into fd359ef on geosolutions-it:master.

@mbarto mbarto merged commit a8de3e5 into geosolutions-it:master Dec 13, 2016
@mbarto mbarto removed the ready label Dec 13, 2016
@manisandro manisandro deleted the measure_on_mouse_move branch December 13, 2016 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants