add boolean properties in UserMenu component (issue 1402) #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarto
suggested changes
Jan 25, 2017
| @@ -58,13 +64,25 @@ const UserMenu = React.createClass({ | |||
| }, | |||
| renderLoggedTools() { | |||
| let DropDown = this.props.nav ? NavDropdown : DropdownButton; | |||
| let showAccountInfoItem = null; | |||
There was a problem hiding this comment.
I think it's better using an array of items and push each enabled item in it
mbarto
suggested changes
Jan 25, 2017
| itemArray.push(<MenuItem key="passwordChange" onClick={this.props.onShowChangePassword}> <Glyphicon glyph="asterisk" /> <Message msgId="user.changePwd"/></MenuItem>); | ||
| } | ||
| if (this.props.showLogout) { | ||
| itemArray.push(<MenuItem key="divider" divider />); |
There was a problem hiding this comment.
I would push the divider only if itemArray.length > 0
mbarto
approved these changes
Jan 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.