#1414 Fixed translations when language changes in the home and manager pages #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me and manager pages
MV88
changed the title
MV88
changed the title
mbarto
approved these changes
Feb 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem also in the manager page for the Users and Groups tools. #1414
They didn't update correctly at the first change of the language.
To solve this I put a {pure: false} options to the connect of the two tools.
In some situations with pure components if only the context changes then the rendering is not performed.
See reduxjs/react-redux#311
Quote from the reference "This will significantly slow it down but context changes will propagate".
I didn't see a significant loss of performace.