-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documented plugin utils #1621
Merged
offtherailz
merged 4 commits into
geosolutions-it:master
from
offtherailz:doc_plugin_utils
Mar 22, 2017
Merged
Documented plugin utils #1621
offtherailz
merged 4 commits into
geosolutions-it:master
from
offtherailz:doc_plugin_utils
Mar 22, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MV88
reviewed
Mar 22, 2017
web/client/utils/PluginsUtils.js
Outdated
@@ -132,6 +137,12 @@ const PluginsUtils = { | |||
const pluginsReducers = getReducers(plugins); | |||
return combineReducers(assign({}, reducers, pluginsReducers)); | |||
}, | |||
/** | |||
* Produces the rootEpic for the plugins, combined wit other epics passed as 2nd argument | |||
* @param {array} plugins the plugins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: with other
offtherailz
added a commit
that referenced
this pull request
Mar 22, 2017
This reverts commit 1839f96.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some documentation for plugin utils method, to clarify how it works.