Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapstore2 Elevation Slider tool #1697

Merged
merged 19 commits into from
Apr 7, 2017
Merged

Mapstore2 Elevation Slider tool #1697

merged 19 commits into from
Apr 7, 2017

Conversation

mricca
Copy link
Contributor

@mricca mricca commented Apr 6, 2017

Layer configuration example:

"params": {
	"DIM_DEPTH": ["1.5"] 
},
"elevations": {
	"name": "DIM_DEPTH", _Name of the elevation params in geoserver_
	"units": "Meters", _Units of Measure_
	"positive": false, _to be set according to the meaning of the variable_
	"showChart": true, _Set to false if you do not view the chart with the slider_
	"values": ["1.5","5.0",...] _hard coded value from the capabilities_
}

Full example:

{
	"group": "METOC Forecasts",
	"name": "gliders:salinity",
	"title": "Salinity",
	"type": "wms",
	"url": "http://cloudsdi.geo-solutions.it/geoserver/wms",
	"bbox": {
		"crs": "EPSG:4326",
			"bounds": {
			"minx": "6",
			"miny": "41",
			"maxx": "13",
			"maxy": "46"
		}
	},
	"visibility": true,
	"singleTile": true,
	"format": "image/png8",
	"params": {
		"DIM_DEPTH": ["1.5"]
	},
	"elevations": {
		"name": "DIM_DEPTH",
		"units": "Meters",
		"positive": false,
		"showChart": true,
		"values": ["1.5","5.0","10.0","15.0","20.0","25.0","30.0","35.0","40.0","45.0","50.0","60.0","70.0","80.0","90.0","100.0","120.0","140.0","160.0","180.0","200.0","225.0","250.0","275.0","300.0","350.0","400.0","450.0","500.0","600.0","700.0","800.0","900.0","1000.0","1200.0","1400.0","1600.0","1800.0","2000.0","2400.0","2800.0"]
	}
}

mricca added 18 commits March 15, 2017 11:17
@mricca
Issue geosolutions-it#1560. Fix Syntax error in themeEntries with nod…
a83d168 
…e v6.10.0 and npm 3.10.10 on windows10 64bit
@mricca
Merge branch 'master' of https://github.com/geosolutions-it/MapStore2
c52f255
@mricca
Merge branch 'master' of https://github.com/geosolutions-it/MapStore2
029faf8
@mricca
Merge branch 'master' of https://github.com/geosolutions-it/MapStore2
3bf499a
@mricca
Merge branch 'master' of https://github.com/geosolutions-it/MapStore2
9014404
@mricca
Merge branch 'master' of https://github.com/geosolutions-it/MapStore2
d9208dc
@mricca
Merge branch 'master' of https://github.com/geosolutions-it/MapStore2
2f7f1ec
@mricca
Merge branch 'master' of https://github.com/geosolutions-it/MapStore2
93cd97b
@mricca
Merge branch 'master' of https://github.com/geosolutions-it/MapStore2
d1a2963
@mricca
Merge branch 'master' of https://github.com/geosolutions-it/MapStore2
1f380ae
@mricca
Merge branch 'master' of https://github.com/geosolutions-it/MapStore2
7710325
@mricca
Merge branch 'master' of https://github.com/geosolutions-it/MapStore2
da1d8ae
@mricca
Merge branch 'master' of https://github.com/geosolutions-it/MapStore2
9bc58a0
@mricca
Merge branch 'master' of https://github.com/geosolutions-it/MapStore2
8f0c362
@mricca
Merge branch 'master' of https://github.com/geosolutions-it/MapStore2
29b1696
@mricca
Merge branch 'master' of https://github.com/geosolutions-it/MapStore2
963c9b5
@mricca
Merge branch 'master' of https://github.com/geosolutions-it/MapStore2
68bd416
@mricca
Merge branch 'master' of https://github.com/geosolutions-it/MapStore2
05e9c04
@simboss simboss added the ready label Apr 6, 2017
MV88
MV88 requested changes Apr 6, 2017
View reviewed changes
web/client/translations/data.de-DE Outdated
@@ -53,6 +54,7 @@
"save": "Speichern",
"saveAs": "Speichern als...",
"opacity": "Deckkraft",
"elevation": "Elevation",
"close": "Schliessen",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be translated this?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 77.329% when pulling be2ae87 on mricca:mapstore2_elevslider into f7437a4 on geosolutions-it:master.

mbarto
mbarto suggested changes Apr 6, 2017
View reviewed changes
web/client/components/TOC/fragments/settings/Elevation.jsx Outdated
</div>
);
},
calcolateRange(values, min, max, dif, firstVal, lastVal) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calculate

web/client/components/TOC/fragments/settings/Elevation.jsx Outdated
let arr = [];
let percText = "";
let range = {min: firstVal, max: lastVal};
values.map(function(currentValue, i) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

map requires a pure function, if you have side effects use forEach

web/client/components/TOC/fragments/settings/Elevation.jsx Outdated
<Slider
snap= {true}
start={[parseFloat((start))] || [0.0]}
range= {this.calcolateRange(values, min, max, dif, firstVal, lastVal)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calculate

package.json Outdated
@@ -161,6 +162,7 @@
"url": "0.10.3",
"uuid": "3.0.1",
"w3c-schemas": "1.3.1",
"wnumb": "1.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have I18N.NumberFormat for number formatting

@mricca
Issue geosolutions-it#1693 Elevation Slider tool
ecc1f84 
Fix requested changes to Elev Slider
@mricca mricca force-pushed the mapstore2_elevslider branch from be2ae87 to ecc1f84 Compare April 6, 2017 16:51
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 77.329% when pulling ecc1f84 on mricca:mapstore2_elevslider into f7437a4 on geosolutions-it:master.

@MV88 MV88 merged commit b41c97a into geosolutions-it:master Apr 7, 2017
@MV88 MV88 removed the ready label Apr 7, 2017
@MV88 MV88 mentioned this pull request Apr 7, 2017
Closed
@mricca mricca deleted the mapstore2_elevslider branch April 7, 2017 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MV88 MV88 MV88 approved these changes

@mbarto mbarto mbarto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mricca @coveralls @mbarto @MV88 @simboss