Set optional drawer menu for share ( see #1632) #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
offtherailz
commented
Apr 6, 2017
offtherailz
commented
- Documented drawer menu plugin
- Added a forceDrawer and a hide option
- Improved share to manage forceDrawer option
- Documented drawer menu plugin - Added a forceDrawer and a hide option - Improved share to manage forceDrawer option
mbarto
suggested changes
Apr 6, 2017
web/client/plugins/DrawerMenu.jsx
Outdated
| @@ -20,7 +20,8 @@ const {Button, Glyphicon, Panel} = require('react-bootstrap'); | |||
| const Section = require('./drawer/Section'); | |||
|
|
|||
| const {partialRight} = require('lodash'); | |||
|
|
|||
| const url = require('url'); | |||
| const query = url.parse(window.location.href, true).query; | |||
There was a problem hiding this comment.
I don't like plugins directly depending from the request. We should use dynamic plugin configuration of plugins to:
- add dynamicity to hide (currently it doesn't support expressions)
- add request params to properties available in expressions (e.g. {request.forceDrawer})
mbarto
suggested changes
Apr 7, 2017
web/client/plugins/DrawerMenu.jsx
Outdated
| const DrawerMenu = React.createClass({ | ||
| propTypes: { | ||
| items: React.PropTypes.array, | ||
| active: React.PropTypes.string, | ||
| hideButton: React.PropTypes.bool, |
mbarto
approved these changes
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.