Fixed #1545 Various fixes to look and feel #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MV88
commented
Apr 7, 2017
MV88
commented
- Added tooltips to drawer menu button and tools
- Changed placeholder from "Select" to "Attribute" in the query form
- Changed position of Theme Swithcer and MapType Switcher
mbarto
reviewed
Apr 7, 2017
web/client/localConfig.json
Outdated
| @@ -108,7 +108,7 @@ | |||
| } | |||
| } | |||
| }, "Login", | |||
| "OmniBar", "BurgerMenu", "Expander" | |||
| "OmniBar", "GridContainer", "BurgerMenu", "Expander" | |||
There was a problem hiding this comment.
Is the GridContainer used in desktop and mobile, or only in the homepage?
web/client/localConfig.json
Outdated
| @@ -202,7 +202,7 @@ | |||
| } | |||
| } | |||
| }, | |||
| "OmniBar", "Login", "Save", "SaveAs", "BurgerMenu", "Expander", "Undo", "Redo", "FullScreen" | |||
| "OmniBar", "GridContainer", "Login", "Save", "SaveAs", "BurgerMenu", "Expander", "Undo", "Redo", "FullScreen" | |||
There was a problem hiding this comment.
Is the GridContainer used in desktop and mobile, or only in the homepage?
MV88
commented
Apr 7, 2017
| @@ -64,6 +65,7 @@ const ComboField = React.createClass({ | |||
| style: { | |||
| width: "100%" | |||
| }, | |||
| placeholder: <Message msgId="queryform.attributefilter.combo_placeholder"/>, | |||
| multivalue: false, | |||
There was a problem hiding this comment.
Probably we can use a different default as placeholder like
"Select..."
mbarto
approved these changes
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.