Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1775 Query panel fails when selecting a boolean attribute #1781

Merged
merged 4 commits into from
May 11, 2017
Merged

Fix #1775 Query panel fails when selecting a boolean attribute #1781

merged 4 commits into from
May 11, 2017

Conversation

allyoucanmap
Copy link
Contributor

  • Added boolean selector to query builder
  • Removed attribute if type is undefinited

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 78.693% when pulling 1788c9c on allyoucanmap:query-bool into 5359643 on geosolutions-it:master.

@offtherailz offtherailz requested review from kappu72 and offtherailz and removed request for kappu72 May 3, 2017 14:28
offtherailz
offtherailz requested changes May 3, 2017
View reviewed changes
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a unit test with boolean. Is the unsupported type case managed?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 79.204% when pulling 904f922 on allyoucanmap:query-bool into c84fd7b on geosolutions-it:master.

@offtherailz offtherailz merged commit fab2eca into geosolutions-it:master May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offtherailz offtherailz offtherailz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allyoucanmap @coveralls @offtherailz