Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1809 Tutorial fails in 3D view mode #1839

Merged
merged 2 commits into from
May 18, 2017

Conversation

allyoucanmap
Copy link
Contributor

  • Added function to check if next step is valid
  • Added custom tooltip component for Cesium

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 79.547% when pulling 18905a4 on allyoucanmap:improve-tutorial into 2a9f77a on geosolutions-it:master.

@offtherailz offtherailz self-requested a review May 18, 2017 08:30
@@ -0,0 +1,116 @@
/*
* Copyright 2017, GeoSolutions Sas.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a component, maybe it should in components/tutorial/steps and tested. The same for the assets

@@ -870,6 +870,29 @@
"examples": {
"title": "Applicazioni personalizzate",
"text": "Puoi utilizzare componenti e plugins di MapStore2 per costruire applicazioni personalizzate"
},
"cesium": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide the translations in italian

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 79.572% when pulling 79f789c on allyoucanmap:improve-tutorial into 2a9f77a on geosolutions-it:master.

@offtherailz offtherailz merged commit f05a3b9 into geosolutions-it:master May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants