Fix #2031 Trigger notification if a map is an old one asking for updating it #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarto
suggested changes
Jul 18, 2017
| * @memberof actions.notifications | ||
| * @returns {object} action | ||
| */ | ||
| function dispatchAction(action) { |
There was a problem hiding this comment.
Are you sure this is needed?
There was a problem hiding this comment.
Yes, it's needed because we need to send custom action when the notification button has been toggled
| @@ -0,0 +1,51 @@ | |||
| const PropTypes = require('prop-types'); | |||
There was a problem hiding this comment.
For new files, let's move this in the right place, please.
offtherailz
requested changes
Jul 18, 2017
| }; | ||
| }; | ||
| const action = dispatchAction(customAction); | ||
| expect(action().type).toBe('CUSTOM_ACTION'); |
There was a problem hiding this comment.
pass simple object. The thunks will be removed in the next future.
web/client/actions/security.js
Outdated
| return (dispatch) => { | ||
| AuthenticationAPI.login(username, password).then((response) => { | ||
| return (dispatch, state) => { | ||
| return AuthenticationAPI.login(username, password).then((response) => { |
There was a problem hiding this comment.
This refreshes can go easily in an epic. Doing it here can cause unwanted side effects.
You should monitor the login/logout actions to reload MapInfo, until you change page.
offtherailz
approved these changes
Jul 19, 2017
MV88
requested changes
Jul 19, 2017
web/client/epics/automapupdate.js
Outdated
| const canEdit = mapInfoLoaded.info && mapInfoLoaded.info.canEdit || false; | ||
| let layers = mapConfigLoaded.config && mapConfigLoaded.config.map && mapConfigLoaded.config.map.layers && mapConfigLoaded.config.map.layers.filter((l) => l.type === 'wms' && l.group !== 'background') || []; | ||
| const options = {bbox: true, search: true, dimensions: true, title: true}; | ||
| return version < 2 && canEdit ? |
MV88
approved these changes
Jul 21, 2017
mbarto
approved these changes
Jul 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2031
Added AutoMapUpdate plugin