Removed additional '?' in WFS request #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offtherailz
requested changes
Jul 21, 2017
web/client/epics/wfsquery.js
Outdated
| @@ -122,8 +123,10 @@ const getWFSFilterData = (filterObj) => { | |||
|
|
|||
| const getWFSFeature = (searchUrl, filterObj) => { | |||
| const data = getWFSFilterData(filterObj); | |||
| const urlParsedObj = Url.parse(searchUrl); | |||
| const parsedUrl = urlParsedObj.protocol + '//' + urlParsedObj.host + urlParsedObj.pathname; | |||
There was a problem hiding this comment.
You should mix the query string parameters (service, outputFormat) with the ones coming from the original URL. So you can keep additional parameters in the URL.
mbarto
reviewed
Jul 21, 2017
web/client/epics/wfsquery.js
Outdated
| return Rx.Observable.defer( () => | ||
| axios.post(searchUrl + '?service=WFS&outputFormat=json', data, { | ||
| axios.post(parsedUrl + params, data, { |
There was a problem hiding this comment.
How is this fixing the original issue of duplicate requests?
offtherailz
changed the title
offtherailz
approved these changes
Jul 28, 2017
offtherailz
requested changes
Jul 28, 2017
web/client/epics/wfsquery.js
Outdated
| const {TOGGLE_CONTROL, setControlProperty} = require('../actions/controls'); | ||
| const querystring = require('querystring'); |
There was a problem hiding this comment.
what's this? I think is missing in package.json
web/client/epics/wfsquery.js
Outdated
| let params = isObject(urlParsedObj.query) ? urlParsedObj.query : {}; | ||
| params.service = 'WFS'; | ||
| params.outputFormat = 'json'; | ||
| const paramsString = querystring.stringify(params); |
There was a problem hiding this comment.
You don't need other libraries. You can do all with Url.format.
Create a new object from urlParsedObj modifying the query object and call Url.format with the new object.
offtherailz
approved these changes
Jul 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an url parser on query to remove additional '?'