Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First implementation of map widgets #2405

Merged
merged 45 commits into from
Nov 21, 2017

Conversation

offtherailz
Copy link
Member

Description

This provides a first implementation of map widgets (charts) functionality.
See the mockup for details

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Feature

What is the current behavior? (You can also link to an open issue here)
No charts available

What is the new behavior?
You can add charts to the map as in the Mockup.

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Other information:

  • The missing things to improve functionalities are listed in the related issue
  • The query builder is now more usable for general purposes (not 2 way binded to the WFS query)
  • Important Note: This pull request introduces and uses some HOCs that should be used everywere, to provide a more consistent interface and simplify/speed up development:
    • emptyState: shows an empty state view (like this) instead of the component, providing a test function. Tj
    • loadingState: shows a loading spinner instead of the component. By default gets the loading prop but supports also a test function.
    • propsStreamFactory: allow to provide a function as argument of a component that generates the properties of the component it is applied: useful to make reusable widgets that do complex async data flows.

mricca and others added 30 commits October 13, 2017 15:39
 - Integrated query panel to edit a filter for the widget editor
 - Improved UI to show the preview in live sync, the selected type
 - Management of the geometry filter mixing query builder's and map one
 - Layout management
 - Error management inside widgets
 - Translations updated
 - Some improvements to color selector
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 81.006% when pulling 88fc23d on offtherailz:widgets into dff8fb5 on geosolutions-it:master.

@geosolutions-it geosolutions-it deleted a comment Nov 17, 2017
@mbarto
Copy link
Contributor

mbarto commented Nov 17, 2017

Some comments:

  • Esporta dati --> Scarica immagine
  • delete confirm dialog --> not translated (in italian at least)
  • line and histo charts --> colors are not updated on combo selection
  • missing title / help button in gauge dialog

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 81.007% when pulling 33547ac on offtherailz:widgets into ddeaa57 on geosolutions-it:master.

@geosolutions-it geosolutions-it deleted a comment Nov 17, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 81.007% when pulling 87e1264 on offtherailz:widgets into ddeaa57 on geosolutions-it:master.

@geosolutions-it geosolutions-it deleted a comment Nov 17, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 81.072% when pulling 756a4d9 on offtherailz:widgets into ddeaa57 on geosolutions-it:master.

 - Now the color selection works also for lines and bars
 - Wizard button moved to the top
 - Improved error management. Now a chart that returns error can not be completed.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 81.06% when pulling 15868c2 on offtherailz:widgets into ddeaa57 on geosolutions-it:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 80.977% when pulling a203383 on offtherailz:widgets into ddeaa57 on geosolutions-it:master.

@offtherailz offtherailz merged commit 4a3c085 into geosolutions-it:master Nov 21, 2017
@offtherailz offtherailz deleted the widgets branch February 18, 2020 11:56
@allyoucanmap allyoucanmap mentioned this pull request Aug 9, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants