MousePosition degrees template via plugin props

[riaanvddool]

Description

Allow MousePosition degrees template to be selected via MousePosition plugin props

Issues

• None
• Discussion: https://groups.google.com/forum/#!topic/mapstore-developers/buz2kpzo09I

Please check if the PR fulfills these requirements

• The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x", remove the others)

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
The default for MousePosition plugin is to display coordinates in DMS format but I need DM.
It is not possible to configure the degreeTemplate from configuration but you can create your own MousPosition Plugin and pass your own template or one from the available ones.

What is the new behavior?
The MousePosition degreesTemplate can now be specified in localConfig.json:

{
          "name": "MousePosition",
          "cfg": {
            "editCRS": true,
            "showLabels": true,
            "showToggle": true,
            "degreesTemplateStr": "MousePositionLabelDM",
            "filterAllowedCRS": ["EPSG:4326", "EPSG:3857"],
            "additionalCRS": {}
}

Does this PR introduce a breaking change? (check one with "x", remove the other)

• Yes
• No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
Discussion: https://groups.google.com/forum/#!topic/mapstore-developers/buz2kpzo09I

[MV88]

move this function outside render() and remove application of parameter
like so

getDegreesTemplateComponent = (degreesTemplateStr) => {
        switch (degreesTemplateStr) {
            case "MousePositionLabelDD" : return require('../components/mapcontrols/mouseposition/MousePositionLabelDD');
            case "MousePositionLabelDM" : return require('../components/mapcontrols/mouseposition/MousePositionLabelDM');
            case "MousePositionLabelDMS" : return require('../components/mapcontrols/mouseposition/MousePositionLabelDMS');
            case "MousePositionLabelDMSNW" : return require('../components/mapcontrols/mouseposition/MousePositionLabelDMSNW');
            default: return require('../components/mapcontrols/mouseposition/MousePositionLabelDMS');
        }
    };

inside render

let degreesTemplateComponent = this.getDegreesTemplateComponent(this.props.degreesTemplateStr);
        return (
            <MousePositionComponent toggle={<MousePositionButton/>} degreesTemplate={degreesTemplateComponent} {...this.props}/>
        );

[MV88]

use 4 space indentation

[MV88]

add property degreesTemplateStr with a default (this will be the one that will be overwritten from localConfig

static propTypes = {
        degreesTemplateStr: PropTypes.string
    };
    static defaultProps = {
        degreesTemplateStr: "MousePositionLabelDMS"
    };

also add :
const PropTypes = require('prop-types');

[MV88]

You can add a unit test if you move this function into a new file MousePositionUtils.js in the utils folder.

then you have to require the function only and use it.

if you need help on how this, do not hesitate to ask

[offtherailz]

Don't know why but travis reported your PR as abuse, so the build didn't start and you couldn't notice the eslint issue notified by Matteo.

I tried to add you to collaborators, I hope it helps. Otherwise you may need to contact travis support, because you may be black-listed (or something else, how knows).
Anyway you can check the issues notified by travis running npm run travis to make you sure that everything is ok for the PR.
Thank you for your contribution.

[offtherailz]

I tried to trigger the build again by closing and opening the pull request but I had the same result.
So I sent a request to support@travis-ci.com to understand the reason of this abuse notification and how to fix it (This may be useful for the future too). We have to wait a reply.

[offtherailz]

I quote the email from support:

Sorry for the confusion.Our system automatically flagged the Terranex organization for possible abuse, but after further review, we were able to clear that up. Any PRs coming from forks of this organization should be now all set to build as normal, though please feel free to contact us should you have any questions or concerns arise. To trigger a build for this PR, I'd recommend pushing a commit to the branch or just closing and reopening the PR directly from GitHub - Hope this helps!

So @riaanvddool you can commit again and you will see the result from travis build.

[mbarto]

Hi Riaan, I make your code a bit more generic here: #2648

Going to close this one. Thanks for the contribution

[riaanvddool]

@mbarto Thanks, I will try it out.