Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2642. Removed entry from counter widget menu #2729

Merged
merged 4 commits into from
Mar 12, 2018

Conversation

amusso01
Copy link
Contributor

@amusso01 amusso01 commented Mar 12, 2018

Description

Fix the dropdown menufor the counter widget

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
dropdown menu presents three elements

What is the new behavior?
now menu presents two elements

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@coveralls
Copy link

coveralls commented Mar 12, 2018

Coverage Status

Coverage increased (+0.004%) to 80.367% when pulling cba4103 on amusso01:master into d4e5e5b on geosolutions-it:master.

Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please we need to:

  • Add a unit test
  • Have the PR description compiled

@ghost ghost removed the pending review label Mar 12, 2018
@offtherailz offtherailz merged commit 5fe67f5 into geosolutions-it:master Mar 12, 2018
@ghost ghost removed In Test review labels Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Widgets: Implement counter widget
4 participants