Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parameters to enable printing end to load version in MapStore2 api #3049

Merged
merged 2 commits into from
Jul 9, 2018

Conversation

kappu72
Copy link
Contributor

@kappu72 kappu72 commented Jul 6, 2018

Description

Added parameters to enable printing end to load version in MapStore2 api

Issues

  • Changes needed to integrate by geonode-mapstore integration
  • ...

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
In MapStore2 api it's impossible to change version url and to enable printing

What is the new behavior?
It's now possible to change version url and to enable printing

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@ghost ghost assigned kappu72 Jul 6, 2018
@kappu72 kappu72 requested a review from mbarto July 6, 2018 09:58
@coveralls
Copy link

coveralls commented Jul 6, 2018

Coverage Status

Coverage remained the same at 80.568% when pulling 8807cd7 on kappu72:api into 1696c83 on geosolutions-it:master.

@@ -188,14 +188,14 @@ const MapStore2 = {
}, {
jsAPIEpic: actionTrigger.epic
});
const initialActions = [...getInitialActions(options), loadVersion];
const initialActions = [...getInitialActions(options), loadVersion(options.versionURL)];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should use bind on loadVersion here, not call the action directly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, where's my head sometimes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants