TimeLine animation range #3291
Merged
TimeLine animation range #3291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
offtherailz
requested changes
Oct 29, 2018
web/client/epics/playback.js
Outdated
| module.exports = { | ||
| retrieveFramesForPlayback: (action$, { getState = () => { } } = {}) => | ||
| action$.ofType(PLAY).exhaustMap( () => | ||
| getDomainValues(...domainArgs(getState)) | ||
| getDomainValues(...domainArgs(getState, { | ||
| time: domainRangeIdentify(playbackRangeSelector(getState()).startPlaybackTime, playbackRangeSelector(getState()).endPlaybackTime) |
There was a problem hiding this comment.
do this transformation inside domainArgs, it is needed also at line 58 (next windows of values requests)
web/client/epics/playback.js
Outdated
| @@ -39,10 +39,14 @@ const domainArgs = (getState, paginationOptions = {}) => { | |||
| ...paginationOptions | |||
| }]; | |||
| }; | |||
| const domainRangeIdentify = (start, end) => `${start}/${end}`; | |||
There was a problem hiding this comment.
As I said in another comment, you have to move this transformation inside domainArgs function.
Anyway if you want to keep a function to identify this operation, you must find a better name.
Checking this probably a good name is something like toAbsoluteInterval
offtherailz
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
see the description
What is the new behavior?
see the description
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: