-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3287 Timeline zoom to current time #3369
#3287 Timeline zoom to current time #3369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still have to try it. but, apart from required changes, it looks good.
The parts of "REMOVE_LAYER" are fixes to previous version or they are a commit error?
@@ -19,6 +19,7 @@ class InlineDateTimeSelector extends React.Component { | |||
static propTypes = { | |||
date: PropTypes.string, | |||
onUpdate: PropTypes.func, | |||
onZoomTo: PropTypes.func, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please name this onIconClick
web/client/epics/playback.js
Outdated
)) | ||
)), | ||
|
||
playbackStopWhenDeleteLayer: (action$, { getState = () => {} }= {}) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a part of the another issue?
web/client/epics/timeline.js
Outdated
@@ -158,8 +159,9 @@ module.exports = { | |||
/** | |||
* Initializes the time line | |||
*/ | |||
setupTimelineExistingSettings: (action$, { getState = () => { } } = {}) => action$.ofType(UPDATE_LAYER_DIMENSION_DATA) | |||
.exhaustMap(() => isAutoSelectEnabled(getState()) && !selectedLayerName(getState()) && get(layersWithTimeDataSelector(getState()), "[0].id") | |||
setupTimelineExistingSettings: (action$, { getState = () => { } } = {}) => action$.ofType(REMOVE_NODE, UPDATE_LAYER_DIMENSION_DATA) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again part of another issue?
These are results from merging an old branch (merged in #3359). |
Description
utilizing the ''currentTime, ''range Start'', and ''Range end'' glyphes in the inlineDateTimeComponent.jsx to zoom/move to the current time or offset range.
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
see #3287
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
waiting for @offtherailz approval I didn't update the localization files, if / once it is approved I'll push a commit with the translations.