Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3287 Timeline zoom to current time #3369

Conversation

baloola
Copy link
Contributor

@baloola baloola commented Nov 27, 2018

Description

utilizing the ''currentTime, ''range Start'', and ''Range end'' glyphes in the inlineDateTimeComponent.jsx to zoom/move to the current time or offset range.

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Feature

What is the current behavior? (You can also link to an open issue here)
see #3287

What is the new behavior?

  • click on the current time icon => timeline move to make the current time in the center of the view range.
  • click on "Range Start"or "Range end" to move timeline so that the offset range is in the center of the view. If the offset range is grater than the view Range, the timeline will zoom out to fit the offset range within the view range (ratio 1 to 5 )

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
waiting for @offtherailz approval I didn't update the localization files, if / once it is approved I'll push a commit with the translations.

Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still have to try it. but, apart from required changes, it looks good.
The parts of "REMOVE_LAYER" are fixes to previous version or they are a commit error?

@@ -19,6 +19,7 @@ class InlineDateTimeSelector extends React.Component {
static propTypes = {
date: PropTypes.string,
onUpdate: PropTypes.func,
onZoomTo: PropTypes.func,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please name this onIconClick

))
)),

playbackStopWhenDeleteLayer: (action$, { getState = () => {} }= {}) =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a part of the another issue?

@@ -158,8 +159,9 @@ module.exports = {
/**
* Initializes the time line
*/
setupTimelineExistingSettings: (action$, { getState = () => { } } = {}) => action$.ofType(UPDATE_LAYER_DIMENSION_DATA)
.exhaustMap(() => isAutoSelectEnabled(getState()) && !selectedLayerName(getState()) && get(layersWithTimeDataSelector(getState()), "[0].id")
setupTimelineExistingSettings: (action$, { getState = () => { } } = {}) => action$.ofType(REMOVE_NODE, UPDATE_LAYER_DIMENSION_DATA)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again part of another issue?

@baloola
Copy link
Contributor Author

baloola commented Nov 29, 2018

These are results from merging an old branch (merged in #3359).
only the last commit is what I add

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 80.568% when pulling 9c73613 on baloola:timeline_zoom_to_currentTime into 0b16bc2 on geosolutions-it:c127_geonode_integration.

@offtherailz offtherailz merged commit da6bcc1 into geosolutions-it:c127_geonode_integration Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants