#9025 WMS caching with custom scales (projection resolutions strategy) #9168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allyoucanmap
added
New Feature
allyoucanmap
changed the title
2 tasks
offtherailz
approved these changes
May 16, 2023
| @@ -439,7 +443,7 @@ class OpenlayersMap extends React.Component { | |||
| updateMapInfoState = () => { | |||
| let view = this.map.getView(); | |||
| let tempCenter = view.getCenter(); | |||
| let projectionExtent = view.getProjection().getExtent() || getExtentForProjection(this.props.projection); | |||
| let projectionExtent = view.getProjection().getExtent() || msGetProjection(this.props.projection).extent; | |||
There was a problem hiding this comment.
This is used twice. IDK exactly why OL extent may be null (and if it should have priority or not).
You can create a function getExtent(this.map, this.props) to centralize and help future refactors and/or changes.
offtherailz
approved these changes
May 17, 2023
|
@ElenaGallo please test this enhancement in dev, thanks. |
allyoucanmap
added a commit
to allyoucanmap/MapStore2
that referenced
this pull request
Jun 14, 2023
offtherailz
added a commit
that referenced
this pull request
Jun 15, 2023
…scales (#9222) * #9025 WMS caching with custom scales (projection resolutions strategy) (#9168) * Fix #9025 WMS caching with custom scales (custom resolutions strategy from WMTS) (#9184) --------- Co-authored-by: Lorenzo Natali <lorenzo.natali@geosolutionsgroup.com> * Fix #9025 Available tile grids popup always reports mismatch in geostories and dashboards (#9196) * Fix #9193 Add a cache options checks/info also for default WMS tile grid (#9195) * Fix #9193 failing test (#9207) * #9025 add caching options to wms background settings (#9213) * fix failing tests --------- Co-authored-by: Lorenzo Natali <lorenzo.natali@geosolutionsgroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the TileGrid options generated for the WMS source of OpenLayers and it reviews following parts:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#9025
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information