Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEOT-7289 Java 9 dependency conflict fixes #291

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

liturner
Copy link

@liturner liturner commented Jan 4, 2023

Merged jt-scale with jt-scale2 (deleting jtscale2) and bumped the guava version in order to improve Java9 Module compatibility.

Relates to https://osgeo-org.atlassian.net/browse/GEOT-7289

This approach has the least impact to the consumers of jai-ext as there are no class or package name changes (jt-scale2 classes each already have unique names and reside in the same package). Other solutions would require downstream projects to refactor their code (e.g. if we were to rename the package).

Downstream Impacts

  • Users of jt-scale will now have an additional dependency on BigInt. Note that this package does not contain license information in its POM which will trigger warnings in tools like the maven license-maven-plugin. A pull request has been openened in the source repo to resolve this moving forward.
  • Users of jt-scale2 will have to switch to the jt-scale maven dependency.

First PR

This is my first PR on this Repo. Maven using Java 8 is successfully "verify"ing on my machine, but I am unsure of how I can further verify the intended functionality. If I have missed any documentation anywhere please let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant