Refactor explore view #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! I just noticed one small thing. When I select a sensor with more than 5 sensors (GREON-01), the sensor popup box is partially out of the view. |
This should be fixed in b66475c. |
aarajh
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The explore view is now fully refactored and uses the newer versions of React and OpenLayers. The PR fixes multiple functionality bugs and interaction issues too.
The bulk of the changes are in
gd-geostreaming/src/containers/Explore. It also required some changes in theMapcomponent ingd-coreto enable some features like layer control for the explore view.gd-gltgis updated to use the new view, but notgd-glmand it needs to be configured for the new view. The rest of the projects are still using the old codebase and need their own tickets for an upgrade.The best way to test this is by running gltg locally (
npm run start -- gd-gltg), going to the explore view (/explore/all), and comparing it with the current view (https://greatlakestogulf.org/explore/all).Check out the issue link to see a list of some of the map interaction stuff that are updated in the new view.
You might want to check out other views too and make sure none of them are broken because of the new changes.
Issue link:
#38
What is the current behavior?
What is the new behavior (if this is a feature change)?
Screenshots (if applicable)
Review Time Estimate
Types of changes (select all that applies)
Checklist: