fix potential flashing bug on map unmount #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is needed for INCORE that completely destroys map sometimes. |
Vismayak
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will fix a potential bug that causes the map to flash when it refreshes or unmounts.
What is the current behavior?
Currently, because there is just a single instance of the map, the flashing issue doesn't occur. Still, if in the future, a new map component is to be used, the current version of the map will keep flashing due to improper detachment of the unmounting Map component.
What is the new behavior (if this is a feature change)?
With the new addition of proper detachment of maps at unmount, it will no longer cause other maps to flash.