Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING CHANGE] Update parsing of lists of keyword entries #287

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

gerlero
Copy link
Owner

@gerlero gerlero commented Nov 25, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.99%. Comparing base (d6178d2) to head (3e12602).

Files with missing lines Patch % Lines
foamlib/_files/_serialization.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
- Coverage   87.05%   86.99%   -0.06%     
==========================================
  Files          16       16              
  Lines        1367     1369       +2     
==========================================
+ Hits         1190     1191       +1     
- Misses        177      178       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gerlero
Copy link
Owner Author

gerlero commented Dec 3, 2024

The old way conflicts with #293, so merging this one now.

@gerlero gerlero merged commit 7805b8f into main Dec 3, 2024
40 checks passed
@gerlero gerlero deleted the files branch December 3, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants