Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hetznerdns_nameserver data source #151

Merged
merged 11 commits into from
Dec 6, 2024
Merged

feat: add hetznerdns_nameserver data source #151

merged 11 commits into from
Dec 6, 2024

Conversation

jkroepke
Copy link
Member

@jkroepke jkroepke commented Dec 5, 2024

@kimdre
Copy link
Member

kimdre commented Dec 5, 2024

@jkroepke I added a new data source to get the available name servers. Unfortunately there is no api endpoint to retrieve them, only a page in their docs.
What do you think? Should we keep the values all hard-coded? Otherwise we could only keep the names hard-coded and resolve the ip addresses at runtime.

Signed-off-by: Kim Oliver Drechsel <kim@drechsel.xyz>
@kimdre kimdre changed the title Add example for DNS zone delegation feat: add hetznerdns_nameserver data source Dec 6, 2024
@kimdre kimdre self-assigned this Dec 6, 2024
@kimdre kimdre added Kind/Feature New functionallity/feature Kind/Documentation Improvements or additions to documentation labels Dec 6, 2024
Signed-off-by: Kim Oliver Drechsel <kim@drechsel.xyz>
Signed-off-by: Kim Oliver Drechsel <kim@drechsel.xyz>
@kimdre
Copy link
Member

kimdre commented Dec 6, 2024

I changed it so that only the nameserver domains are hard-coded and the the ip addresses get resolved at runtime.

@kimdre kimdre enabled auto-merge (squash) December 6, 2024 15:49
@kimdre kimdre disabled auto-merge December 6, 2024 15:50
Signed-off-by: Kim Oliver Drechsel <kim@drechsel.xyz>
Signed-off-by: Kim Oliver Drechsel <kim@drechsel.xyz>
Signed-off-by: Kim Oliver Drechsel <kim@drechsel.xyz>
@kimdre kimdre merged commit 7618419 into main Dec 6, 2024
6 checks passed
@kimdre kimdre deleted the ns-docs branch December 6, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind/Documentation Improvements or additions to documentation Kind/Feature New functionallity/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants