Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for pandas 2.1.0 #327

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Updates for pandas 2.1.0 #327

merged 3 commits into from
Sep 5, 2023

Conversation

maread99
Copy link
Collaborator

@maread99 maread99 commented Sep 4, 2023 •
edited
Loading

Updates dependencies including pandas from 2.0.3 to 2.1.0.

The pandas update has introduced a bug and some warnings that have necessitated changes (more changes in fact that than the move from pandas 1.5 to 2.0!).

  • Fixes Cannot create calendar with observance with pandas 2.1 #326 - updates functions passed to Holiday observance option. These functions now all take a datetime.datetime, never a pandas.DatetimeIndex.
    • This required notable changes to the XBUD and XTAI modules which both relied on previously being able to, effectively, observe a single holiday on multiple days (this provided for adding an extra holiday on a Friday/Monday when the official holiday fell on a Thursday/Tuesday and the extra day's holiday is stipulated to bridge the weekend and the official holiday). This is no longer an option, such that these 'bridge' days now require their own Holiday calendar.
  • Fixes FutureWarning raised when indexing a pandas.Series directly with an int rather than via Series.iloc.
  • Suppresses new hypothesis HealthCheck concerned with multiple executors.

@maread99
Fix holiday observance
45d4e24 
Fixes #326

Updates functions passed to Holiday observance. Functions updated
to always take a `datetime.datetime` and never a `pandas.DatetimeIndex`.
@maread99
Update dependencies
87b4bba 
Includes updating pandas from 2.0.3 to 2.1.0.
@maread99 maread99 added dependencies Pull requests that update a dependency file maintenance fix Bug fix labels Sep 4, 2023
@maread99 maread99 requested review from gerrymanoim and removed request for gerrymanoim September 4, 2023 17:58
@maread99
Accommodate dependency updates
01b39ad 
Fixes `FutureWarning` raised when indexing a `pandas.Series` directly
with an `int` rather than via `Series.iloc`.

Surpresses new hypothesis HealthCheck concerned with multiple executors.
@maread99 maread99 removed the request for review from gerrymanoim September 5, 2023 07:45
@maread99 maread99 merged commit 85f7ed7 into master Sep 5, 2023
8 checks passed
@maread99 maread99 deleted the obs-fix branch September 5, 2023 07:48
This was referenced Sep 5, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file fix Bug fix maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot create calendar with observance with pandas 2.1
1 participant
@maread99