Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSHG: Add 2023-10-06 as a holiday #330

Merged

Conversation

philiptromans
Copy link

This PR adds 2023-10-06 as a holiday in XSHG. It's the last working day of the Mid-Autumn Festival and China’s National Day holiday. SSE source: http://english.sse.com.cn/start/trading/schedule/

Workflow to modify an existing Exchange Calendar

  • Modify calendar class as required.
  • Modify the test resources file (e.g tests/resources/{Exchange MIC}.csv), either manually or by executing python etc/make_exchange_calendar_test_csv.py {Exchange MIC}.
  • Check if any of the fixtures in tests/test_{Exchange MIC}_calendar.py need updating to reflect your changes.
  • Add references to any new/modified holidays in exchange_calendars/exchange_calendar_{Exchange MIC}.py.

…Mid-Autumn Festival and China’s National Day" holiday).
@maread99 maread99 added the calendar update Calendar needs updating label Sep 7, 2023
@maread99
Copy link
Collaborator

maread99 commented Sep 7, 2023

Thanks @philiptromans. I'll merge after # 329.

@maread99 maread99 merged commit 08f332f into gerrymanoim:master Sep 9, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
calendar update Calendar needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants