XTKS: Add 2024 Vernal and Autumnal equinoxes #342
Merged
+225
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @Quashqwart! |
|
Hi @maread99, |
|
Hi @Quashqwart, it was just what I mentioned earlier, that the actual date could be removed. Only the observed date is required, as for the previous years. Thanks. |
According to https://www.jpx.co.jp/english/corporate/about-jpx/calendar/index.html, https://www.timeanddate.com/holidays/japan/spring-equinox, and https://www.timeanddate.com/holidays/japan/autumn-equinox, in 2024 Vernal Equinox will happen on Mar. 20 (Wed.), and Autumnal Equinox will happen on Sep. 22 (Sun.)., observed on Sep. 23 (Mon.)
Quashqwart
force-pushed
the
fix-xtks-2024
branch
from
61d847f
to
67de79e
Compare
|
Thanks @Quashqwart! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to
https://www.jpx.co.jp/english/corporate/about-jpx/calendar/index.html, https://www.timeanddate.com/holidays/japan/spring-equinox, and https://www.timeanddate.com/holidays/japan/autumn-equinox, in 2024 Vernal Equinox will happen on Mar. 20 (Wed.), and Autumnal Equinox will happen on Sep. 22 (Sun.)., observed on Sep. 23 (Mon.)
Workflow to modify an existing Exchange Calendar
tests/resources/{Exchange MIC}.csv), either manually or by executingpython etc/make_exchange_calendar_test_csv.py {Exchange MIC}.tests/test_{Exchange MIC}_calendar.pyneed updating to reflect your changes.exchange_calendars/exchange_calendar_{Exchange MIC}.py.