Bundle src code and plugin into docker image #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From now on it's bundled into the docker image.
Th src code and the test folders don't need to be mapped into container in production. Src code is bundled into the docker image.
|
@nitaibezerra, com isto poderíamos retirar o parâmetro install-deps do Makefile e a instrução make install-deps no Readme? |
|
Sim. Bem lembrado. Vou corrigir isso e subir aqui nesse PR. Aviso aqui!
Sent from [ProtonMail](https://protonmail.com), Swiss-based encrypted email.
Enviado via Proton Mail para dispositivos móveis
…-------- Mensagem Original --------
Em 20 de mar de 2023 11:28, Eduardo Lauer escreveu:
***@***.***(https://github.com/nitaibezerra), com isto poderíamos retirar o parâmetro install-deps do Makefile e a instrução make install-deps no Readme?
—
Reply to this email directly, [view it on GitHub](#53 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAJP2GZPWMXZ2PTF6CRBCR3W5BSRLANCNFSM6AAAAAAV7OCCNM).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@edulauer feito! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the Dockerfile adding some steps to install the Ro-dou src code and FastETL plugin code in build time instead of mapping them as docker volumes.
It simplifies production deployment.
Fix #52