Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify Repository and Serde traits, introduce AnyRepository, remove ProtobufSerde #270

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

ar3s3ru
Copy link
Collaborator

@ar3s3ru ar3s3ru commented Dec 11, 2023

  • feat(aggregate::repository): expose single Repository trait, add AnyRepository extension
  • refactor: use new Repository unified trait, switch to AnyRepository in examples
  • refactor(serde): unify the Serde trait, remove serde-protobuf feature
  • refactor(eventually): move to nested, local mod.rs pattern

@ar3s3ru ar3s3ru changed the title refactor/any repository and serde trait refactor: simplify Repository and Serde traits, introduce AnyRepository, remove ProtobufSerde Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (f04295a) 87.33% compared to head (191273c) 91.53%.
Report is 1 commits behind head on main.

Files Patch % Lines
...entually/src/aggregate/repository/event_sourced.rs 89.58% 5 Missing ⚠️
eventually/src/aggregate/repository/any.rs 90.00% 2 Missing ⚠️
eventually/src/tracing.rs 0.00% 2 Missing ⚠️
eventually/src/aggregate/repository/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
+ Coverage   87.33%   91.53%   +4.19%     
==========================================
  Files          17       17              
  Lines        1161     1158       -3     
==========================================
+ Hits         1014     1060      +46     
+ Misses        147       98      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ar3s3ru ar3s3ru merged commit 406edf8 into main Dec 11, 2023
8 checks passed
@ar3s3ru ar3s3ru deleted the refactor/any-repository-and-serde-trait branch December 11, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant