Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Make the factory upgradeable #75

Merged
merged 5 commits into from
Mar 31, 2024
Merged

✨ Make the factory upgradeable #75

merged 5 commits into from
Mar 31, 2024

Conversation

qd-qd
Copy link
Member

@qd-qd qd-qd commented Mar 31, 2024

No description provided.

qd-qd added 5 commits March 31, 2024 20:17
Refactor the factory to be upgradeable. The implementation
is expected to be consumed by a transparent proxy.
This commit update the factory scripts regarding the last
changes in the factory's implementation. It also exposes
new scripts to interact with the factory.
@qd-qd qd-qd self-assigned this Mar 31, 2024
Copy link

Changes to gas cost

Generated at commit: 203fc7fd9b8e200564ea3a2b5f8865da0b5591ed, compared to commit: 06c4aa3d75e76e47cba534a21d9b8fb94370f42e

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
AccountFactory renounceOwnership
transferOwnership
-18,620 ✅
-21,388 ✅
-79.87%
-81.56%
AccountFactoryHarness transferOwnership -21,159 ✅ -74.72%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AccountFactory 1,387,464 (+134,878) createAndInitAccount
owner
renounceOwnership
transferOwnership
9,508 (-25,476)
363 (+22)
2,417 (-20,769)
2,549 (-21,389)
-72.82%
+6.45%
-89.58%
-89.35%
37,592 (-24,924)
1,220 (-121)
4,692 (-18,620)
4,836 (-21,388)
-39.87%
-9.02%
-79.87%
-81.56%
15,011 (-25,012)
363 (-978)
4,692 (-18,620)
4,836 (-21,388)
-62.49%
-72.93%
-79.87%
-81.56%
233,118 (-25,476)
2,363 (+22)
6,967 (-16,471)
7,124 (-21,387)
-9.85%
+0.94%
-70.27%
-75.01%
287 (0)
7 (+1)
2 (0)
2 (0)
AccountFactoryHarness 1,441,219 (+138,538) exposed_isSignatureLegit
transferOwnership
3,982 (+22)
7,159 (-21,159)
+0.56%
-74.72%
6,915 (+22)
7,159 (-21,159)
+0.32%
-74.72%
5,976 (+22)
7,159 (-21,159)
+0.37%
-74.72%
9,533 (+22)
7,159 (-21,159)
+0.23%
-74.72%
1,282 (0)
1 (0)
ERC1967Proxy 168,642 (0) isValidSignature 32,678 (0) 0.00% 180,021 (+14,010) +8.44% 45,852 (0) 0.00% 605,939 (+84,063) +16.11% 12 (0)
SmartAccountERC1271__EIP191 8,116,630 (+1,164,913)
SmartAccountERC1271__EIP712 8,143,673 (+1,164,916)
AccountFactory__GetAddress 4,921,893 (-134,989)

@qd-qd qd-qd merged commit 91d63e1 into main Mar 31, 2024
4 checks passed
@qd-qd qd-qd deleted the factory/make-it-upgradeable branch March 31, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant