🔨 make BaseScript more generic/powerful
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This light refactoring of BaseScript makes it more generic and powerful. Based on the flag you provide when running the script, it will either start the hardware wallet flow or use the private key you provide. In addition, I added new comments for each script to detail how to use them.
qd-qd
changed the title
BaseScript more generic/powerful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This light refactoring of BaseScript makes it more generic and powerful. Based on the flags you provide when running the script, it will either start the hardware wallet flow or use the private key you provide.
In addition, I added new comments for each script to detail how to use them.
Closes #3