One-liner: Added a variable declaration for our for...in loop #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very interesting! Quite surprised this isn't causing a crash tbh, thanks for tagging me on the review :) |
stephanis1494
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assigning @stephanis1494 since I think this is technically frontend related? 😅
But! This is a simple (kind of) fix I found while working on our rollup bundler in the medal-electron repo
This declares the
ivariable in the for...in loop, which for some reason, Electron complains about, but I think other JS engines let slide? Either way, in the for...in MDN Docs it mentions that this variable needs to be declared, thus, I think it's probably worth doing this either way. 😄Screenshot of tests still passing