chore: Do not loop gifs

get10101 · May 7, 2024 · 77dd96a · 77dd96a
1 parent 6168453
commit 77dd96a
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 11 deletions.
diff --git a/mobile/assets/error.gif b/mobile/assets/error.gif
diff --git a/mobile/assets/info.gif b/mobile/assets/info.gif
diff --git a/mobile/assets/success.gif b/mobile/assets/success.gif
diff --git a/mobile/lib/common/task_status_dialog.dart b/mobile/lib/common/task_status_dialog.dart
@@ -46,16 +46,35 @@ class _TaskStatusDialog extends State<TaskStatusDialog> {
 
   bool timeout = false;
 
+  Image? coverImage;
+
   @override
   void dispose() {
-    _timeout?.cancel();
     super.dispose();
+    _timeout?.cancel();
+
+    // we need to evict the image cache to ensure that the gif is re-run next time.
+    coverImage?.image.evict();
   }
 
   @override
   Widget build(BuildContext context) {
     bool isPending = widget.task.status == TaskStatus.pending;
 
+    // we need to evict the image cache to ensure that the gif is re-run next time.
+    coverImage?.image.evict();
+
+    coverImage = Image.asset(
+      widget.successAnim != null && widget.task.status == TaskStatus.success
+          ? widget.successAnim!
+          : switch (widget.task.status) {
+              TaskStatus.pending => AppAnim.loading,
+              TaskStatus.failed => AppAnim.error,
+              TaskStatus.success => AppAnim.success,
+            },
+      fit: BoxFit.cover,
+    );
+
     if (_timeout != null) {
       // cancel already running timeout timer if we receive a new update.
       _timeout!.cancel();
@@ -109,16 +128,7 @@ class _TaskStatusDialog extends State<TaskStatusDialog> {
               decoration: const BoxDecoration(
                 color: Colors.white,
               ),
-              child: Image.asset(
-                widget.successAnim != null && widget.task.status == TaskStatus.success
-                    ? widget.successAnim!
-                    : switch (widget.task.status) {
-                        TaskStatus.pending => AppAnim.loading,
-                        TaskStatus.failed => AppAnim.error,
-                        TaskStatus.success => AppAnim.success,
-                      },
-                fit: BoxFit.cover,
-              ),
+              child: coverImage,
             ),
             const SizedBox(height: 15),
             if (widget.showSuccessTitle) buildTitle(widget.task.status),