fix: Invalid commitment tx signature from peer after processing pending Accept or CloseAccept message #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holzeis
changed the title
bonomat
reviewed
Aug 28, 2023
Error happens when the pending `Accept` or `CloseAccept` message is processed after connection has lost and the channel is re-established again.
Drop pending `Accept` and `CloseAccept` messages after peer disconnects.
holzeis
force-pushed
the
fix/invalid-commitment-tx-signature-from-peer
branch
from
d5d04a7 to
5ec59d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error happens when the pending
AcceptorCloseAcceptmessage is processed after connection has lost and the channel is re-established again.The first commit e9bdf05 reproduces the errors reported in #1074 and #1141.
The second commit 5ec59d2 points to the fix in
rust-dlcp2pderivatives/rust-dlc#142. Note, this is still pointing to the PR as it is waiting a review. We may want to want for the merge there before merging this PR.fixes #1074
fixes #1141
Note, already broken channels will not get recovered with that fix and have to be force-closed.