Improve app debugging experience #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the exports are not parsed as logs by log viewers, e.g. `lnav`,
which makes in needlessly more difficult
We don't need to run all the services, including funding etc; we don't use them when testing against public regtest. Rename the command to `ios-regtest`
Prevent unneeded channel state and price update events by caching the last
values and comparing them before sending an update.
This log didn't add anything.
klochowicz
force-pushed
the
chore/improve-app-debugging-experience
branch
from
30662a1 to
5c6be9a
Compare
|
Merging because this is immediately useful to debug #1187. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of commits aimed at making it easier to parse the logs.
See commits for details
below screenshot of lnav finally parsing the app logs correctly:
