Fix: send on-chain #1900
Merged
Fix: send on-chain #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now one can copy the invoice (which includes bitcoin:...?amount) and the address only. Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
It looks like the issue was a problem of poping the modal async. Since we don't do a lightning payment at the moment we can fall back to good ol sync payments. Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
bonomat
force-pushed
the
fix/sending-on-chain
branch
from
e0ac803 to
4fa3816
Compare
holzeis
approved these changes
Jan 25, 2024
| walletService.sendPayment(widget.destination, widget.amount).catchError((error) { | ||
| try { | ||
| walletService.sendOnChainPayment(widget.destination, widget.amount); | ||
| setState(() => sent = true); |
There was a problem hiding this comment.
nit: To be consistent with the previous implementation this should go after the try catch.
However, this will anyways not be needed when we drop uspd and lightning payments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on phone and simulator. Let's see if this was really the issue :/
resolves #1892
Note: I made a small UI change: Allow users to copy the address only (without
bitcoin:) in front of it.