feat: Add min margin to channel trade constraints #1906
Conversation
holzeis
force-pushed
the
chore/set-minimum-amount-to-1-when-dlc-channel-is-open
branch
from
8cf5ed1 to
99c0529
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
holzeis
deleted the
chore/set-minimum-amount-to-1-when-dlc-channel-is-open
branch
| @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| - Chore: Set minimum quantity to 1 if dlc channel is open | |||
There was a problem hiding this comment.
Won't this result in tiny DLCs that cannot be claimed on-chain?
There was a problem hiding this comment.
Won't this result in tiny DLCs that cannot be claimed on-chain?
Aren't we considering the full amount on the CET transaction including any potential off chain amount.
So I think we only have to care about the initial margin to be big enough for a channel but afterwards there shouldn't be a limit.
Either party may loose so much that their payout can't be claimed anymore. But I don't think that's a problem.
There was a problem hiding this comment.
I think you are right!
I do think eventually we should track whether either side is getting too close to the dust limit, to at least inform about this.
There was a problem hiding this comment.
I do think eventually we should track whether either side is getting too close to the dust limit, to at least inform about this.
afaik rust-dlc is taking care of this.
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-01-26.at.15.49.13.mp4