New carousel #1917
Merged
New carousel #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonomat
force-pushed
the
chore/new-charousel
branch
from
e34920f to
6955cc4
Compare
bonomat
force-pushed
the
chore/new-charousel
branch
from
6955cc4 to
cd2863a
Compare
luckysori
reviewed
Jan 31, 2024
There was a problem hiding this comment.
🙃 A starting margin and price marker would be useful to help the user understand when they earn or lose money.
There was a problem hiding this comment.
Also, it's not clear that they are going long in all scenarios.
Comment on lines
+176
to
+180
| return LineTooltipItem( | ||
| 'at ${formatter.format(touchedSpot.x)} \n you get ₿${touchedSpot.y.toStringAsFixed(8)}', |
There was a problem hiding this comment.
🔧 This tooltip doesn't look so good in the video. It always overlaps with some other element of the UI.
There was a problem hiding this comment.
I leave these changes for now and let this be reworked when we use this component in a different setting.
bonomat
force-pushed
the
chore/new-charousel
branch
from
a7bd083 to
34c9d23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will resolve #1846
The chart is an extra component, maybe we can add this in the trading screen somewhere. Could be useful to display this information to the user.
Simulator.Screen.Recording.-.iPhone.15.-.2024-01-30.at.16.35.54.mp4