fix: remove one possible panic #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had an issue where the app would panic because we fell behind in the protocol. This panic has been removed in this commit bonomat/rust-lightning-p2p-derivatives@e49030e. Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
holzeis
reviewed
Jan 30, 2024
| @@ -30,13 +30,13 @@ dlc = { git = "https://github.com/p2pderivatives/rust-dlc", rev = "69d63e1" } | |||
| p2pd-oracle-client = { git = "https://github.com/p2pderivatives/rust-dlc", rev = "69d63e1" } | |||
There was a problem hiding this comment.
I think we also need to update our rust-dlc lightning dependencies.
There was a problem hiding this comment.
It's not needed, I've tested it locally.
holzeis
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue where the app would panic because we fell behind in the protocol. This panic has been removed in this commit bonomat/rust-lightning-p2p-derivatives@e49030e.
This commit was built on top of our latest commit p2pderivatives/rust-lightning@121bc32
I didn't feel good about pushing this to our usual fork in https://github.com/p2pderivatives/rust-lightning because it sounds dangerous and hence pushed it onto my own fork. We can drop this again in the future.
(hopefully) resolves most panics.
Resolves #1911