feat(webapp): show tradingview chart #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holzeis
approved these changes
Feb 7, 2024
| </script> | ||
| </div> | ||
| </body> | ||
| </html> |
| ProgressIndicatorType type = ProgressIndicatorType.circular; | ||
|
|
||
| @override | ||
| void initState() { |
There was a problem hiding this comment.
nit: this initState does not have to be overridden.
| class _TradingViewWidgetHtmlState extends State<TradingViewWidgetHtml> { | ||
| final GlobalKey webViewKey = GlobalKey(); | ||
| InAppWebViewController? webViewController; | ||
| double progress = 0; |
There was a problem hiding this comment.
🤔 It looks like this progress and type fields are not used?
bonomat
force-pushed
the
feat/trading-view
branch
from
66efde6 to
833468d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
bonomat
force-pushed
the
feat/trading-view
branch
from
833468d to
01f2e91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes a "small" redesign of the webapp :D 🙈
resolves #1950
Checkout my technical analytic skills ;) 70k by 1 Nov sounds about right :)
Screen.Recording.2024-02-06.at.4.31.28.pm.mov