Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store os in db #2493

Merged
merged 1 commit into from
Apr 30, 2024
Merged

feat: store os in db #2493

merged 1 commit into from
Apr 30, 2024

Conversation

bonomat
Copy link
Contributor

@bonomat bonomat commented Apr 29, 2024

@holzeis
Copy link
Contributor

holzeis commented Apr 29, 2024

@bonomat how would that look for iOS? Does it include the version?

@bonomat
Copy link
Contributor Author

bonomat commented Apr 29, 2024

@bonomat how would that look for iOS? Does it include the version?

it does not include a version, only the os, i.e. one of these values: https://doc.rust-lang.org/std/env/consts/constant.OS.html

@holzeis
Copy link
Contributor

holzeis commented Apr 29, 2024

@bonomat how would that look for iOS? Does it include the version?

it does not include a version, only the os, i.e. one of these values: doc.rust-lang.org/std/env/consts/constant.OS.html

With the device_info_plus (which I think we are already using) we can get the os version as well.

@bonomat
Copy link
Contributor Author

bonomat commented Apr 29, 2024

@bonomat how would that look for iOS? Does it include the version?

it does not include a version, only the os, i.e. one of these values: doc.rust-lang.org/std/env/consts/constant.OS.html

With the device_info_plus (which I think we are already using) we can get the os version as well.

doesn't look like we are using this: https://github.com/search?q=repo%3Aget10101%2F10101%20device_info_plus&type=code

@@ -0,0 +1,2 @@
ALTER TABLE users
ADD COLUMN os TEXT;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 Missing newline

@bonomat bonomat force-pushed the feat/store-os-for-user branch from b9d4ca4 to 31fb86e Compare April 30, 2024 00:19
@bonomat bonomat enabled auto-merge April 30, 2024 00:20
@bonomat bonomat added this pull request to the merge queue Apr 30, 2024
Merged via the queue into get10101:main with commit 0d8157b Apr 30, 2024
22 checks passed
@bonomat bonomat deleted the feat/store-os-for-user branch April 30, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants