Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show pending trade dialog immediately when submitting an order #2507

Merged
merged 1 commit into from
May 8, 2024

Conversation

holzeis
Copy link
Contributor

@holzeis holzeis commented May 8, 2024

Otherwise, a short delay could happen after submitting the order before the dialog is shown. This was more obvious on the test vm the other day, when the submit order request timed out.

Otherwise, a short delay could happen after submitting the order before the dialog is shown. This was more obvious on the test vm the other day, when the submit order request timed out.
@holzeis holzeis requested review from bonomat and luckysori May 8, 2024 06:26
@holzeis holzeis self-assigned this May 8, 2024
@holzeis holzeis enabled auto-merge May 8, 2024 06:33
@holzeis holzeis added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit 02bd2fb May 8, 2024
22 of 23 checks passed
@holzeis holzeis deleted the fix/show-pending-dialog-immediately branch May 8, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants