Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle error when requesting a hodl invoice #2573

Merged
merged 1 commit into from
May 29, 2024

Conversation

holzeis
Copy link
Contributor

@holzeis holzeis commented May 28, 2024

If we can't receive a hodl invoice the app gracefully handles that scenario and shows an according message instead of the invoice.

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-28.at.14.59.14.mp4

@holzeis holzeis requested review from bonomat and luckysori May 28, 2024 13:00
@holzeis holzeis self-assigned this May 28, 2024
If we can't receive a hodl invoice the app gracefully handles that scenario and shows an according message instead of the invoice.
@holzeis holzeis enabled auto-merge May 28, 2024 13:01
Copy link
Contributor

@bonomat bonomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhm, it only says now: coming soon if we couldn't get the invoice.
But I guess this is good enough.

@holzeis holzeis added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 42d9e30 May 29, 2024
23 checks passed
@holzeis holzeis deleted the fix/resilient-onboarding branch May 29, 2024 01:58
@holzeis
Copy link
Contributor Author

holzeis commented May 29, 2024

Mhm, it only says now: coming soon if we couldn't get the invoice.

But I guess this is good enough.

I wanted to do something with else but I wasn't able to design something nice so I reused the coming soon image. 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants