Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cancel hodl invoice if dlc proposal fails #2590

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

holzeis
Copy link
Contributor

@holzeis holzeis commented May 31, 2024

fixes #2586
fixes #2589

We can't really know if the invoice failed or got canceled. I think canceled is the better state name though.
At the coordinator startup we stopped all tasks watching invoices. Thus we can safely set all `Open` or `Accepted`  (pending) invoices to `Canceled`.
@holzeis holzeis requested review from bonomat and luckysori May 31, 2024 14:16
@holzeis holzeis self-assigned this May 31, 2024
Copy link
Contributor

@bonomat bonomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holzeis holzeis added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit 1b9e50b Jun 4, 2024
24 checks passed
@holzeis holzeis deleted the chore/set-timedout-invoices-to-canceled branch June 4, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set timed out hodl invoices to canceled Cancel hodl invoice if dlc proposal failed
2 participants