Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't overflow UI on small screens #2631

Closed
wants to merge 2 commits into from

Conversation

Restioson
Copy link
Contributor

@Restioson Restioson commented Jun 17, 2024

Addresses #1933 partially. This does remove all overflow on small mobile screens that I could find, but it doesn't make it nice necessarily in all cases (see below...)

Unfortunately, there is still one issue which will be harder to resolve:

  • When the screen is very small, the position/order list in the trade tab correctly scrolls
  • However, the TradingView chart takes up the lion's share of the space, meaning that you are viewing the position/order list through a pinhole, which is very frustrating and hard to see
  • The ideal UX solution is to scroll the entire page - not just the position list. This way, the trading view widget will eventually disappear if you scroll down far enough.
  • However, this is difficult. We can't just wrap the entire thing in a scroll widget because TabBarView also creates a scroll widget, so it won't work properly. If we remove the scroll widget in TabBarView, it has unconstrained height and refuses to lay itself out. IntrinsicHeight is flat-out disallowed it seems(?). The correct solution is a NestedScrollView, but this is a bit of a pain to implement.

Because it may take a bit longer to fix the trade screen, I've opened this PR in the meantime, as these fixes are separate.

@Restioson Restioson requested review from holzeis and bonomat and removed request for holzeis June 17, 2024 14:01
@holzeis
Copy link
Contributor

holzeis commented Jun 17, 2024

Can you add before and after screenshots?

Regarding the trading view. How about adjusting its height proportionally to the available space?

@Restioson
Copy link
Contributor Author

Restioson commented Jun 18, 2024

Can you add before and after screenshots?

I can do this

Regarding the trading view. How about adjusting its height proportionally to the available space?

I think that could be a good solution! We can revisit it and make the scroll nice and fancy later if we want.

@github-actions github-actions bot added the Stale label Jul 19, 2024
@github-actions github-actions bot closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants