Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: log client pubkey if available #92

Merged
merged 7 commits into from
Jul 31, 2024
Merged

Conversation

im-adithya
Copy link
Member

@im-adithya im-adithya commented Jul 15, 2024

Should I instead add client_pubkey and wallet_pubkey columns to the subscriptions table? That would make it easier, currently it looks bad.

@im-adithya im-adithya requested a review from bumi July 15, 2024 13:26
Copy link
Contributor

@bumi bumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it an authors array? doesn't an event only have one pubkey?

internal/nostr/nostr.go Outdated Show resolved Hide resolved
@im-adithya
Copy link
Member Author

Why is it an authors array? doesn't an event only have one pubkey?

Because we internally use subscriptions logic when we poll for a response from the relay. That's why we make sure the subscriptions.RequestEvent exists which tells us that it is NIP-47 Response fetching subscription invoked by NIP47Handler

internal/nostr/nostr.go Outdated Show resolved Hide resolved
@im-adithya im-adithya merged commit 58669eb into main Jul 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants