feat: lazy parallel loading of lightning address data #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
that looks good! tanks for the pr |
rolznz
reviewed
Aug 5, 2024
rolznz
reviewed
Aug 6, 2024
| @@ -75,31 +75,45 @@ export default class LightningAddress { | |||
| ); | |||
| const json = await result.json(); | |||
|
|
|||
| await this.parseResponse(json.lnurlp, json.keysend, json.nostr); | |||
| await this.parseLnUrlPayResponse(json.lnurlp); | |||
There was a problem hiding this comment.
why is this one async and the others aren't? did you miss something in your refactoring?
There was a problem hiding this comment.
No I haven't. Good eye. First one uses utils await parseLnUrlPayResponse() because sha256 is async. Others doesn't have async code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for proxy usage there is no change.